Page MenuHomePhabricator

Add Dashboard typeaheads
ClosedPublic

Authored by chad on Dec 16 2016, 3:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 8:08 PM
Unknown Object (File)
Sun, Dec 15, 2:47 PM
Unknown Object (File)
Fri, Dec 13, 7:24 AM
Unknown Object (File)
Mon, Dec 9, 5:58 AM
Unknown Object (File)
Mon, Dec 9, 5:58 AM
Unknown Object (File)
Mon, Dec 9, 5:56 AM
Unknown Object (File)
Mon, Dec 9, 5:51 AM
Unknown Object (File)
Mon, Dec 2, 9:26 AM
Subscribers

Details

Summary

Builds a basic typeahead for Dashboards and Panels

Test Plan

/typeahead/browse/PhabricatorDashboardPanelDatasource/

Diff Detail

Repository
rP Phabricator
Branch
dashboard-typeahead (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14941
Build 19580: Run Core Tests
Build 19579: arc lint + arc unit

Event Timeline

chad retitled this revision from to Add Dashboard typeaheads.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

Some potential issues:

  • Many dashboards have similar names (we have like 100 dashboards on this install called "New Simple Dashboard" or something), so it's probably often hard to select the right one or tell if you're selecting the right one? Including the dashboard ID or author might help. If this can find things by ID at least it's always possible to do what you want, but I suspect right now it's impossible in many cases (at least, without explicitly going and renaming the dashboard).
  • I think this problem is likely worse for panels, which we likely have more of, and which tend to have similar names, and which are more inconvenient to rename.
  • This won't perform efficiently, since there's no index it can query against. The dataset is probably small enough that this doesn't matter too much, but I suspect reasonable installs may have enough dashboards/panels that this is perceptibly laggy.
  • I believe that when the are more than a page of results for a given query in the "Browse" dialog, pagination won't work. It seems plausible for either object type to reach a full page of results.

None of this is a major concern.

src/applications/dashboard/storage/PhabricatorDashboardPanel.php
120–122

getIsArchived() should be automatically generated?

This revision is now accepted and ready to land.Dec 16 2016, 12:00 PM
This revision was automatically updated to reflect the committed changes.