Builds a basic typeahead for Dashboards and Panels
Details
Details
- Reviewers
epriestley - Commits
- rP0387d626325c: Add Dashboard typeaheads
/typeahead/browse/PhabricatorDashboardPanelDatasource/
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- dashboard-typeahead (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 14941 Build 19580: Run Core Tests Build 19579: arc lint + arc unit
Event Timeline
Comment Actions
Some potential issues:
- Many dashboards have similar names (we have like 100 dashboards on this install called "New Simple Dashboard" or something), so it's probably often hard to select the right one or tell if you're selecting the right one? Including the dashboard ID or author might help. If this can find things by ID at least it's always possible to do what you want, but I suspect right now it's impossible in many cases (at least, without explicitly going and renaming the dashboard).
- I think this problem is likely worse for panels, which we likely have more of, and which tend to have similar names, and which are more inconvenient to rename.
- This won't perform efficiently, since there's no index it can query against. The dataset is probably small enough that this doesn't matter too much, but I suspect reasonable installs may have enough dashboards/panels that this is perceptibly laggy.
- I believe that when the are more than a page of results for a given query in the "Browse" dialog, pagination won't work. It seems plausible for either object type to reach a full page of results.
None of this is a major concern.
src/applications/dashboard/storage/PhabricatorDashboardPanel.php | ||
---|---|---|
120–122 | getIsArchived() should be automatically generated? |