Paths

Table of Contentst

Differential D17065

Add EditEngine typeahead
ClosedPublic
Actions

Authored by chad on Dec 16 2016, 5:48 AM.

Details

Reviewers

epriestley

Commits

rP92db64c1b247: Add EditEngine typeahead

Summary

Allows you to set forms via typeahead

Test Plan

/typeahead/browse/PhabricatorEditEngineDatasource/

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 41053.Dec 16 2016, 5:48 AM

chad retitled this revision from to Add EditEngine typeahead.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptDec 16 2016, 5:48 AM

Potential issues on D17064 mostly apply here, too, but nothing too critical.

This revision is now accepted and ready to land.Dec 16 2016, 12:01 PM

I just build ngram indexes for them or is there something simpler? I plan to make these more useful in the next pass.

ngram indexes are the simplest available approach.

Closed by commit rP92db64c1b247: Add EditEngine typeahead (authored by chad, committed by chad). · Explain WhyDec 16 2016, 4:40 PM

This revision was automatically updated to reflect the committed changes.

Realized here tonight that builtin forms don't have PHIDs, so the typeahead only works with Custom Forms. Any easy solution?

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

transactions/

typeahead/

PhabricatorEditEngineDatasource.php

39 lines

Diff 41069

View Options

src/__phutil_library_map__.php