Differential D17061

Fix a Differential exception in invalid/missing fields
ClosedPublic
Actions

Authored by epriestley on Dec 15 2016, 7:24 PM.

Details

Reviewers

chad

Maniphest Tasks

T11114: Move Differential to EditEngine

Commits

rP89d88dafcc41: Fix a Differential exception in invalid/missing fields

Summary

Ref T11114. Missed this while converting.

Test Plan

Tried to create a revision with no test plan. Before: fatal; after: helpful message.

Diff Detail

Repository

rP Phabricator

Branch

diff20

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14931
Build 19565: Run Core Tests
Build 19564: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 41043.Dec 15 2016, 7:24 PM

epriestley retitled this revision from to Fix a Differential exception in invalid/missing fields.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11114: Move Differential to EditEngine.

chad accepted this revision.Dec 15 2016, 7:24 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 15 2016, 7:24 PM

Closed by commit rP89d88dafcc41: Fix a Differential exception in invalid/missing fields (authored by epriestley, committed by epriestley). · Explain WhyDec 15 2016, 7:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

parser/

DifferentialCommitMessageParser.php

4 lines

Diff 41043

View Options

src/applications/differential/parser/DifferentialCommitMessageParser.php

Fix a Differential exception in invalid/missing fieldsClosedPublicActions