Page MenuHomePhabricator

Truncate the one-line diff update summary when updating a revision to 250 bytes
ClosedPublic

Authored by epriestley on Dec 13 2016, 5:31 PM.
Tags
None
Referenced Files
F14384437: D17038.id40985.diff
Sat, Dec 21, 10:33 AM
F14384416: D17038.id41002.diff
Sat, Dec 21, 10:32 AM
Unknown Object (File)
Sun, Dec 15, 4:07 PM
Unknown Object (File)
Fri, Dec 13, 8:10 PM
Unknown Object (File)
Fri, Dec 13, 4:43 AM
Unknown Object (File)
Thu, Dec 12, 10:36 AM
Unknown Object (File)
Mon, Dec 9, 9:22 AM
Unknown Object (File)
Thu, Nov 28, 10:07 PM
Subscribers
None

Details

Summary

Fixes T7899. If you create or update a revision and type an enormously long first line, we currently fatal trying to insert it into the database.

This text is only used to show a single-line summary of the diff in the "History" tab, which should probably be updated anyway. For now, stop fataling.

Test Plan

Uploaded a diff with the description "MMMM..." (thousands of them).

Before patch: fatal on description being too long.
After patch: beautiful "MMMM" summary.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Truncate the one-line diff update summary when updating a revision to 250 bytes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 13 2016, 5:45 PM
This revision was automatically updated to reflect the committed changes.