Page MenuHomePhabricator

Truncate the one-line diff update summary when updating a revision to 250 bytes
ClosedPublic

Authored by epriestley on Dec 13 2016, 5:31 PM.

Details

Summary

Fixes T7899. If you create or update a revision and type an enormously long first line, we currently fatal trying to insert it into the database.

This text is only used to show a single-line summary of the diff in the "History" tab, which should probably be updated anyway. For now, stop fataling.

Test Plan

Uploaded a diff with the description "MMMM..." (thousands of them).

Before patch: fatal on description being too long.
After patch: beautiful "MMMM" summary.

Diff Detail

Repository
rP Phabricator
Branch
diff1
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 14874
Build 19473: Run Core Tests
Build 19472: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40985.Dec 13 2016, 5:31 PM
epriestley retitled this revision from to Truncate the one-line diff update summary when updating a revision to 250 bytes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Dec 13 2016, 5:45 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 13 2016, 5:45 PM
This revision was automatically updated to reflect the committed changes.