Page MenuHomePhabricator
Differential D17038

Truncate the one-line diff update summary when updating a revision to 250 bytes
ClosedPublic
Actions

Authored by epriestley on Dec 13 2016, 5:31 PM.
Tags
None
Referenced Files
F14482692: D17038.diff
Mon, Dec 30, 10:17 AM
Unknown Object (File)
Sat, Dec 21, 10:33 AM
Unknown Object (File)
Sat, Dec 21, 10:32 AM
Unknown Object (File)
Sun, Dec 15, 4:07 PM
Unknown Object (File)
Fri, Dec 13, 8:10 PM
Unknown Object (File)
Fri, Dec 13, 4:43 AM
Unknown Object (File)
Thu, Dec 12, 10:36 AM
Unknown Object (File)
Mon, Dec 9, 9:22 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T7899: DifferentialDiff->description is "text255?" but should be "text"
Commits
rPfc6bfbdb103f: Truncate the one-line diff update summary when updating a revision to 250 bytes
Summary

Fixes T7899. If you create or update a revision and type an enormously long first line, we currently fatal trying to insert it into the database.

This text is only used to show a single-line summary of the diff in the "History" tab, which should probably be updated anyway. For now, stop fataling.

Test Plan

Uploaded a diff with the description "MMMM..." (thousands of them).

Before patch: fatal on description being too long.
After patch: beautiful "MMMM" summary.

Diff Detail

Repository
rP Phabricator
Branch
diff1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14874
Build 19473: Run Core Tests
Build 19472: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40985.Dec 13 2016, 5:31 PM
epriestley retitled this revision from to Truncate the one-line diff update summary when updating a revision to 250 bytes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T7899: DifferentialDiff->description is "text255?" but should be "text".
chad accepted this revision.Dec 13 2016, 5:45 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 13 2016, 5:45 PM
Closed by commit rPfc6bfbdb103f: Truncate the one-line diff update summary when updating a revision to 250 bytes (authored by epriestley, committed by epriestley). · Explain WhyDec 13 2016, 10:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
conduit/
9 lines

Diff 40985

View Options

src/applications/differential/conduit/DifferentialConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility