Page MenuHomePhabricator
Differential D17028

Rename all ProfilePanels into ProfileMenuItems
ClosedPublic
Actions

Authored by epriestley on Dec 11 2016, 6:54 PM.
Tags
None
Referenced Files
F13148139: D17028.diff
Fri, May 3, 9:02 PM
Unknown Object (File)
Fri, May 3, 3:54 AM
Unknown Object (File)
Mon, Apr 29, 4:01 PM
Unknown Object (File)
Thu, Apr 25, 2:05 AM
Unknown Object (File)
Fri, Apr 19, 5:51 PM
Unknown Object (File)
Thu, Apr 11, 8:07 AM
Unknown Object (File)
Mon, Apr 8, 1:22 AM
Unknown Object (File)
Mar 28 2024, 9:25 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11957: Add MenuEngine to Home
Commits
rP42896f9f9044: Rename all ProfilePanels into ProfileMenuItems
Summary

Ref T11957.

Test Plan
  • Viewed an existing project profile.
  • Viewed a user profile.
  • Created a new project.
  • Edited a profile menu.
  • Added new profile items.
  • Grepped for renamed symbols.

Diff Detail

Repository
rP Phabricator
Branch
panel4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14846
Build 19430: Run Core Tests
Build 19429: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40957.Dec 11 2016, 6:54 PM
epriestley retitled this revision from to Rename all ProfilePanels into ProfileMenuItems.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11957: Add MenuEngine to Home.
epriestley updated this revision to Diff 40958.Dec 11 2016, 7:08 PM
  • Fix a get() instead of set() when editing properties of a menu item.
chad accepted this revision.Dec 11 2016, 7:23 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 11 2016, 7:23 PM
Closed by commit rP42896f9f9044: Rename all ProfilePanels into ProfileMenuItems (authored by epriestley, committed by epriestley). · Explain WhyDec 11 2016, 7:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
60 lines
applications/
base/
18 lines
people/
application/
4 lines
controller/
2 lines
2 lines
2 lines
2 lines
engine/
38 lines
menuitem/
profilepanel/
PhabricatorPeopleDetailsProfileMenuItem.php
PhabricatorPeopleDetailsProfilePanel.php
8 lines
PhabricatorPeopleManageProfileMenuItem.php
PhabricatorPeopleManageProfilePanel.php
10 lines
profilepanel/
project/
application/
4 lines
controller/
2 lines
4 lines
2 lines
4 lines
2 lines
PhabricatorProjectMenuItemController.php
PhabricatorProjectPanelController.php
2 lines
2 lines
2 lines
6 lines
engine/
47 lines
menuitem/
profilepanel/
PhabricatorProjectDetailsProfileMenuItem.php
PhabricatorProjectDetailsProfilePanel.php
8 lines
PhabricatorProjectManageProfileMenuItem.php
PhabricatorProjectManageProfilePanel.php
10 lines
PhabricatorProjectMembersProfileMenuItem.php
PhabricatorProjectMembersProfilePanel.php
8 lines
PhabricatorProjectPointsProfileMenuItem.php
PhabricatorProjectPointsProfilePanel.php
8 lines
PhabricatorProjectSubprojectsProfileMenuItem.php
PhabricatorProjectSubprojectsProfilePanel.php
8 lines
PhabricatorProjectWorkboardProfileMenuItem.php
PhabricatorProjectWorkboardProfilePanel.php
8 lines
profilepanel/
storage/
14 lines
search/
editor/
26 lines
engine/
341 lines
menuitem/
profilepanel/
PhabricatorApplicationProfileMenuItem.php
PhabricatorApplicationProfilePanel.php
10 lines
PhabricatorDividerProfileMenuItem.php
PhabricatorDividerProfilePanel.php
10 lines
PhabricatorLinkProfileMenuItem.php
PhabricatorLinkProfilePanel.php
14 lines
PhabricatorMotivatorProfileMenuItem.php
PhabricatorMotivatorProfilePanel.php
12 lines
PhabricatorProfileMenuItem.php
PhabricatorProfilePanel.php
16 lines
PhabricatorProfileMenuItemIconSet.php
PhabricatorProfilePanelIconSet.php
4 lines
profilepanel/
query/
20 lines
storage/
32 lines
docs/
user/
userguide/
2 lines

Diff 40957

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/base/PhabricatorApplication.php

Loading...
View Options

src/applications/people/application/PhabricatorPeopleApplication.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileEditController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileManageController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfilePictureController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Loading...
View Options

src/applications/people/engine/PhabricatorPeopleProfileMenuEngine.php

Loading...
View Options

src/applications/people/menuitem/PhabricatorPeopleDetailsProfileMenuItem.php

Loading...
View Options

src/applications/people/menuitem/PhabricatorPeopleManageProfileMenuItem.php

Loading...
View Options

src/applications/people/profilepanel/PhabricatorPeopleDetailsProfilePanel.php

Loading...
View Options

src/applications/people/profilepanel/PhabricatorPeopleManageProfilePanel.php

Loading...
View Options

src/applications/project/application/PhabricatorProjectApplication.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectEditPictureController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectManageController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectMembersViewController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectMenuItemController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectPanelController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectSubprojectsController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectViewController.php

Loading...
View Options

src/applications/project/engine/PhabricatorProjectProfileMenuEngine.php

Loading...
View Options

src/applications/project/menuitem/PhabricatorProjectDetailsProfileMenuItem.php

Loading...
View Options

src/applications/project/menuitem/PhabricatorProjectManageProfileMenuItem.php

Loading...
View Options

src/applications/project/menuitem/PhabricatorProjectMembersProfileMenuItem.php

Loading...
View Options

src/applications/project/menuitem/PhabricatorProjectPointsProfileMenuItem.php

Loading...
View Options

src/applications/project/menuitem/PhabricatorProjectSubprojectsProfileMenuItem.php

Loading...
View Options

src/applications/project/menuitem/PhabricatorProjectWorkboardProfileMenuItem.php

Loading...
View Options

src/applications/project/profilepanel/PhabricatorProjectDetailsProfilePanel.php

Loading...
View Options

src/applications/project/profilepanel/PhabricatorProjectManageProfilePanel.php

Loading...
View Options

src/applications/project/profilepanel/PhabricatorProjectMembersProfilePanel.php

Loading...
View Options

src/applications/project/profilepanel/PhabricatorProjectPointsProfilePanel.php

Loading...
View Options

src/applications/project/profilepanel/PhabricatorProjectSubprojectsProfilePanel.php

Loading...
View Options

src/applications/project/profilepanel/PhabricatorProjectWorkboardProfilePanel.php

Loading...
View Options

src/applications/project/storage/PhabricatorProject.php

Loading...
View Options

src/applications/search/editor/PhabricatorProfileMenuEditEngine.php

Loading...
View Options

src/applications/search/engine/PhabricatorProfileMenuEngine.php

Loading...
View Options

src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php

Loading...
View Options

src/applications/search/menuitem/PhabricatorDividerProfileMenuItem.php

Loading...
View Options

src/applications/search/menuitem/PhabricatorLinkProfileMenuItem.php

Loading...
View Options

src/applications/search/menuitem/PhabricatorMotivatorProfileMenuItem.php

Loading...
View Options

src/applications/search/menuitem/PhabricatorProfileMenuItem.php

Loading...
View Options

src/applications/search/menuitem/PhabricatorProfileMenuItemIconSet.php

Loading...
View Options

src/applications/search/profilepanel/PhabricatorApplicationProfilePanel.php

Loading...
View Options

src/applications/search/profilepanel/PhabricatorDividerProfilePanel.php

Loading...
View Options

src/applications/search/profilepanel/PhabricatorLinkProfilePanel.php

Loading...
View Options

src/applications/search/profilepanel/PhabricatorMotivatorProfilePanel.php

Loading...
View Options

src/applications/search/profilepanel/PhabricatorProfilePanel.php

Loading...
View Options

src/applications/search/profilepanel/PhabricatorProfilePanelIconSet.php

Loading...
View Options

src/applications/search/query/PhabricatorProfileMenuItemConfigurationQuery.php

Loading...
View Options

src/applications/search/storage/PhabricatorProfileMenuItemConfiguration.php

Loading...
View Options

src/docs/user/userguide/profile_menu.diviner

Loading...
Phabricator · Built by Phacility