Differential D17013

Fix an issue where tokenizers can sort milestone results into the wrong query phase
ClosedPublic
Actions

Authored by epriestley on Dec 9 2016, 2:11 PM.

Details

Reviewers

chad

Maniphest Tasks

T11955: Tag autocomplete doesn't always include milestones

Commits

rP9c38b61e51a0: Fix an issue where tokenizers can sort milestone results into the wrong query…

Summary

Fixes T11955. Currently, milestones have an internal name of "Parent (Milestone) ...".

This makes them look like they're prefix matches for "Parent", but they're actually prefix matches for "Milestone".

Reorder the names so that the internal name is "Milestone Parent ...".

Test Plan

Created a project "AAA" with milestone "BBB". Searched for "AAA", found "AAA" and milestone "AAA (BBB)".

Diff Detail

Repository

rP Phabricator

Branch

milestone2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14819
Build 19388: Run Core Tests
Build 19387: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40932.Dec 9 2016, 2:11 PM

epriestley retitled this revision from to Fix an issue where tokenizers can sort milestone results into the wrong query phase.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11955: Tag autocomplete doesn't always include milestones.

epriestley mentioned this in T11955: Tag autocomplete doesn't always include milestones.Dec 9 2016, 2:12 PM

chad accepted this revision.Dec 9 2016, 4:03 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 9 2016, 4:03 PM

Closed by commit rP9c38b61e51a0: Fix an issue where tokenizers can sort milestone results into the wrong query… (authored by epriestley, committed by epriestley). · Explain WhyDec 9 2016, 4:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

typeahead/

PhabricatorProjectDatasource.php

13 lines

Diff 40932

View Options

src/applications/project/typeahead/PhabricatorProjectDatasource.php

Fix an issue where tokenizers can sort milestone results into the wrong query phaseClosedPublicActions