Differential D17002

Cache README content for repositories
ClosedPublic
Actions

Authored by epriestley on Dec 6 2016, 5:37 PM.

Details

Reviewers

chad

Maniphest Tasks

T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching

Commits

rPb869e742b9dc: Cache README content for repositories

Summary

Ref T11954. Especially with higher-latency file stores like S3, we can spend a lot of time reading README data and then pulling it out of file storage.

Instead, cache it.

Test Plan

Browsed a repostory with a README, saw faster pages.

Diff Detail

Repository

rP Phabricator

Branch

ccache9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14791
Build 19340: Run Core Tests
Build 19339: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40905.Dec 6 2016, 5:37 PM

epriestley retitled this revision from to Cache README content for repositories.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching.

chad accepted this revision.Dec 6 2016, 5:45 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 6 2016, 5:45 PM

Closed by commit rPb869e742b9dc: Cache README content for repositories (authored by epriestley, committed by epriestley). · Explain WhyDec 6 2016, 5:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionController.php

67 lines

Diff 40905

View Options

src/applications/diffusion/controller/DiffusionController.php

Cache README content for repositoriesClosedPublicActions