Page MenuHomePhabricator
Differential D16974

When resolving a relative date, only ignore the viewer timezone if the date has a timezone
ClosedPublic
Actions

Authored by epriestley on Dec 2 2016, 12:54 PM.
Tags
None
Referenced Files
F14669465: D16974.diff
Sun, Jan 12, 3:52 PM
Unknown Object (File)
Tue, Jan 7, 1:27 PM
Unknown Object (File)
Dec 5 2024, 12:11 PM
Unknown Object (File)
Dec 4 2024, 6:26 PM
Unknown Object (File)
Dec 1 2024, 4:48 PM
Unknown Object (File)
Nov 28 2024, 4:01 AM
Unknown Object (File)
Nov 27 2024, 4:11 AM
Unknown Object (File)
Nov 25 2024, 9:59 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11801: Calendar: ICS Import Errata
Commits
rPHU3230179f3ce5: (stable) Promote 2016 Week 49
rPHU213c7339ccd3: When resolving a relative date, only ignore the viewer timezone if the date has…
Summary

Ref T11801. In some cases, we generate a relative date without having a timezone. In these cases, use the viewer timezone.

Test Plan
  • Added a failing test case and made it pass.
  • Imported the event from T11801#202293, which failed before this change and worked after it.
  • Also added a reduced version of that event as a .ics test case since I caught a different bug. See next change.

Diff Detail

Repository
rPHU libphutil
Branch
relativeviewertimezone
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14731
Build 19250: Run Core Tests
Build 19249: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40846.Dec 2 2016, 12:54 PM
epriestley retitled this revision from to When resolving a relative date, only ignore the viewer timezone if the date has a timezone.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11801: Calendar: ICS Import Errata.
epriestley mentioned this in D16975: Set the viewer timezone properly on Calendar event RecurrenceSet objects.Dec 2 2016, 12:57 PM
epriestley mentioned this in T11801: Calendar: ICS Import Errata.Dec 2 2016, 12:58 PM
chad accepted this revision.Dec 2 2016, 3:22 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 2 2016, 3:22 PM
Closed by commit rPHU213c7339ccd3: When resolving a relative date, only ignore the viewer timezone if the date has… (authored by epriestley, committed by epriestley). · Explain WhyDec 2 2016, 3:29 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in rP7c37377e0d61: Set the viewer timezone properly on Calendar event RecurrenceSet objects.

Revision Contents
Changeset List

PathSize
src/
parser/
calendar/
data/
5 lines
__tests__/
20 lines
ics/
__tests__/
26 lines
data/
14 lines

Diff 40846

View Options

src/parser/calendar/data/PhutilCalendarRelativeDateTime.php

Loading...
View Options

src/parser/calendar/data/__tests__/PhutilCalendarDateTimeTestCase.php

Loading...
View Options

src/parser/calendar/ics/__tests__/PhutilICSParserTestCase.php

Loading...
View Options

src/parser/calendar/ics/__tests__/data/weekly.ics

Loading...
Phabricator · Built by Phacility