Page MenuHomePhabricator

Implement basic IPv6 address parsing support
ClosedPublic

Authored by epriestley on Dec 2 2016, 12:07 PM.
Tags
None
Referenced Files
F15445359: D16973.id40845.diff
Thu, Mar 27, 1:33 PM
F15445346: D16973.diff
Thu, Mar 27, 1:31 PM
F15445267: D16973.diff
Thu, Mar 27, 1:11 PM
F15439950: D16973.diff
Wed, Mar 26, 10:27 AM
F15434252: D16973.id.diff
Tue, Mar 25, 2:47 AM
F15399828: D16973.diff
Mon, Mar 17, 7:57 AM
F15389864: D16973.diff
Sat, Mar 15, 5:42 AM
F15377314: D16973.id40845.diff
Thu, Mar 13, 8:35 AM
Subscribers
None
Tokens
"Love" token, awarded by 20after4.

Details

Summary

Ref T11939. I'll hold this until after the release cut. We still need CIDR support (although that looks straightforward) and then testing, which should be only slightly painful since AWS supports IPv6 with some caveats now.

Test Plan

Added unit tests; ran unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
ipv6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14730
Build 19248: Run Core Tests
Build 19247: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Implement basic IPv6 address parsing support.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 2 2016, 3:20 PM
This revision was automatically updated to reflect the committed changes.