Page MenuHomePhabricator

Explicitly update the repository URI index after making a URI edit
ClosedPublic

Authored by epriestley on Dec 1 2016, 10:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 5:49 PM
Unknown Object (File)
Fri, Apr 19, 5:48 PM
Unknown Object (File)
Thu, Apr 11, 8:14 AM
Unknown Object (File)
Thu, Apr 4, 4:13 AM
Unknown Object (File)
Wed, Mar 27, 5:33 PM
Unknown Object (File)
Mar 10 2024, 5:03 AM
Unknown Object (File)
Feb 23 2024, 3:13 AM
Unknown Object (File)
Feb 21 2024, 5:36 AM
Subscribers
None

Details

Summary

Fixes T11936. After editing a repository URI, we were not correctly updating the URI index.

Any other edit to the repository would update the index, and this index is only really used by arc to figure out which repository a working copy belongs to, so that's how this evaded detection for this long. In particular, creating a repository would usually have an edit after any URI edits, to activate it, which would build the index correctly.

Test Plan
  • Added a new URI to a repository.
  • Verified it was immediately reflected in the repository_uriindex table.

Diff Detail

Repository
rP Phabricator
Branch
uriindex
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14728
Build 19245: Run Core Tests
Build 19244: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Explicitly update the repository URI index after making a URI edit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 1 2016, 10:27 PM
This revision was automatically updated to reflect the committed changes.