Paths

Table of Contentst

Fix local time test case for logged-out viewers using global settings
ClosedPublic
Actions

Authored by epriestley on Nov 28 2016, 2:53 PM.

Tags

None

Referenced Files

	F19074110: D16952.id.diff
	Mon, Dec 1, 4:23 AM

	F19067864: D16952.diff
	Sun, Nov 30, 11:05 AM

	F19057013: D16952.id40806.diff
	Fri, Nov 28, 9:13 PM

	F19044448: D16952.diff
	Thu, Nov 27, 3:08 AM

	F19024782: D16952.diff
	Mon, Nov 24, 4:19 AM

	F18854074: D16952.diff
	Oct 31 2025, 9:32 PM

	F18819045: D16952.diff
	Oct 22 2025, 3:56 AM

	F18813109: D16952.id40806.diff
	Oct 20 2025, 2:06 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Commits

rPab3b70739614: Fix local time test case for logged-out viewers using global settings

Summary

In D16936, I changed logged-out viewers so they use global settings.

This can lead to a SELECT from an isolated unit test. Instead, give the test fixtures and use standard generateNewUser() stuff.

Test Plan

Ran arc unit --everything.

Diff Detail

Repository

rP Phabricator

Branch

unit1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14687
Build 19186: Run Core Tests
Build 19185: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40799.Nov 28 2016, 2:53 PM

epriestley retitled this revision from to Fix local time test case for logged-out viewers using global settings.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Nov 28 2016, 4:59 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 28 2016, 4:59 PM

Closed by commit rPab3b70739614: Fix local time test case for logged-out viewers using global settings (authored by epriestley, committed by epriestley). · Explain WhyNov 28 2016, 5:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

__tests__/

PhabricatorLocalTimeTestCase.php

10 lines

Diff 40799

View Options

src/view/tests/PhabricatorLocalTimeTestCase.php

Fix local time test case for logged-out viewers using global settingsClosedPublicActions