Page MenuHomePhabricator
Differential D16952

Fix local time test case for logged-out viewers using global settings
ClosedPublic
Actions

Authored by epriestley on Nov 28 2016, 2:53 PM.
Tags
None
Referenced Files
F15459208: D16952.id40806.diff
Mon, Mar 31, 10:57 AM
F15452573: D16952.id.diff
Sat, Mar 29, 6:03 AM
F15449872: D16952.diff
Fri, Mar 28, 12:35 PM
F15445077: D16952.id40799.diff
Thu, Mar 27, 12:24 PM
F15389182: D16952.id40806.diff
Sat, Mar 15, 4:58 AM
F15334836: D16952.id40799.diff
Sat, Mar 8, 12:30 PM
Unknown Object (File)
Sun, Mar 2, 7:42 PM
Unknown Object (File)
Mar 1 2025, 3:52 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
rPab3b70739614: Fix local time test case for logged-out viewers using global settings
Summary

In D16936, I changed logged-out viewers so they use global settings.

This can lead to a SELECT from an isolated unit test. Instead, give the test fixtures and use standard generateNewUser() stuff.

Test Plan

Ran arc unit --everything.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40799.Nov 28 2016, 2:53 PM
epriestley retitled this revision from to Fix local time test case for logged-out viewers using global settings.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Nov 28 2016, 4:59 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 28 2016, 4:59 PM
Closed by commit rPab3b70739614: Fix local time test case for logged-out viewers using global settings (authored by epriestley, committed by epriestley). · Explain WhyNov 28 2016, 5:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
__tests__/
10 lines

Diff 40806

View Options

src/view/__tests__/PhabricatorLocalTimeTestCase.php

Loading...
Phabricator · Built by Phacility