Page MenuHomePhabricator
Differential D16951

Remove english from lightbox javascript
ClosedPublic
Actions

Authored by chad on Nov 28 2016, 1:59 AM.
Tags
None
Referenced Files
F13149108: D16951.diff
Sat, May 4, 6:49 AM
Unknown Object (File)
Fri, Apr 19, 5:46 PM
Unknown Object (File)
Sat, Apr 6, 9:02 AM
Unknown Object (File)
Mar 30 2024, 8:50 PM
Unknown Object (File)
Feb 13 2024, 4:16 AM
Unknown Object (File)
Feb 10 2024, 9:33 PM
Unknown Object (File)
Feb 3 2024, 1:13 PM
Unknown Object (File)
Jan 20 2024, 11:11 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T3612: Lightbox v2
Commits
rP3edd01bc0fa2: Remove english from lightbox javascript
Summary

Reduces to x / y for lightbox. Adds spacing. Ref T3612

Test Plan

Review spacing in sandbox.

Diff Detail

Repository
rP Phabricator
Branch
pht-files (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14686
Build 19184: Run Core Tests
Build 19183: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40798.Nov 28 2016, 1:59 AM
chad retitled this revision from to Remove english from lightbox javascript.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T3612: Lightbox v2.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 28 2016, 1:59 AM
epriestley accepted this revision.Nov 28 2016, 2:43 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 28 2016, 2:43 PM
Closed by commit rP3edd01bc0fa2: Remove english from lightbox javascript (authored by chad, committed by chad). · Explain WhyNov 28 2016, 4:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
30 lines
webroot/
rsrc/
css/
phui/
2 lines
js/
core/
2 lines

Diff 40798

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/phui/phui-lightbox.css

Loading...
View Options

webroot/rsrc/js/core/behavior-lightbox-attachments.js

Loading...
Phabricator · Built by Phacility