Page MenuHomePhabricator

When a Phortune subscription has a removed payment method, be more explicit about it
ClosedPublic

Authored by epriestley on Nov 23 2016, 9:37 PM.
Tags
None
Referenced Files
F18035538: D16935.id.diff
Sun, Aug 3, 1:35 AM
F17963761: D16935.diff
Fri, Aug 1, 10:49 AM
F17617671: D16935.diff
Wed, Jul 9, 4:36 PM
Unknown Object (File)
Jun 19 2025, 11:45 PM
Unknown Object (File)
May 11 2025, 11:59 PM
Unknown Object (File)
May 10 2025, 10:15 AM
Unknown Object (File)
May 8 2025, 5:13 AM
Unknown Object (File)
Apr 8 2025, 1:14 AM
Subscribers
None

Details

Summary

Currently, when a payment method is invalid we still render the full name and let you save the form without making changes. This can be confusing.

Instead:

  • Render "<Deleted Payment Method>", literally.
  • Render an error immediately.
  • Prevent the form from being saved without changing the method.
Test Plan

Screen Shot 2016-11-23 at 1.35.34 PM.png (1×1 px, 135 KB)

Diff Detail

Repository
rP Phabricator
Branch
autopay1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14652
Build 19134: Run Core Tests
Build 19133: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to When a Phortune subscription has a removed payment method, be more explicit about it.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2016, 9:50 PM
This revision was automatically updated to reflect the committed changes.