Page MenuHomePhabricator

When a Phortune subscription has a removed payment method, be more explicit about it
ClosedPublic

Authored by epriestley on Nov 23 2016, 9:37 PM.
Tags
None
Referenced Files
F18843662: D16935.id.diff
Wed, Oct 29, 12:00 AM
F18838288: D16935.diff
Mon, Oct 27, 10:07 AM
F18813285: D16935.id.diff
Mon, Oct 20, 3:07 PM
F18457510: D16935.diff
Sep 1 2025, 12:41 PM
F18103984: D16935.id40764.diff
Aug 10 2025, 9:04 AM
F18035538: D16935.id.diff
Aug 3 2025, 1:35 AM
F17963761: D16935.diff
Aug 1 2025, 10:49 AM
F17617671: D16935.diff
Jul 9 2025, 4:36 PM
Subscribers
None

Details

Summary

Currently, when a payment method is invalid we still render the full name and let you save the form without making changes. This can be confusing.

Instead:

  • Render "<Deleted Payment Method>", literally.
  • Render an error immediately.
  • Prevent the form from being saved without changing the method.
Test Plan

Screen Shot 2016-11-23 at 1.35.34 PM.png (1×1 px, 135 KB)

Diff Detail

Repository
rP Phabricator
Branch
autopay1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14652
Build 19134: Run Core Tests
Build 19133: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to When a Phortune subscription has a removed payment method, be more explicit about it.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2016, 9:50 PM
This revision was automatically updated to reflect the committed changes.