Page MenuHomePhabricator
Differential D16928

Modularize Arcanist settings, let users pick between ambiguous interpretations of `arc browse ...`
ClosedPublic
Actions

Authored by epriestley on Nov 23 2016, 4:31 PM.
Tags
None
Referenced Files
F14044816: D16928.diff
Tue, Nov 12, 9:39 PM
F14037916: D16928.diff
Sun, Nov 10, 8:08 PM
F14023193: D16928.diff
Wed, Nov 6, 11:51 PM
F13991870: D16928.id.diff
Tue, Oct 22, 1:10 PM
F13964495: D16928.id40760.diff
Tue, Oct 15, 8:45 PM
Unknown Object (File)
Oct 9 2024, 6:17 AM
Unknown Object (File)
Oct 2 2024, 7:28 AM
Unknown Object (File)
Oct 1 2024, 6:19 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`
Commits
rARCdc4e0f788d8e: Modularize Arcanist settings, let users pick between ambiguous interpretations…
Summary

Ref T10895. This modularizes Arcanist settings, but doesn't do anything with them yet.

When users type arc browse X, and only provide one "X", and there are several ways to interpret it, prompt them to choose one.

Test Plan

Created a file named T234, ran arc browse T234, was prompted to interpret it as an object or a path.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40749.Nov 23 2016, 4:31 PM
epriestley retitled this revision from to Modularize Arcanist settings, let users pick between ambiguous interpretations of `arc browse ...`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`.
chad accepted this revision.Nov 23 2016, 5:02 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2016, 5:02 PM
Closed by commit rARCdc4e0f788d8e: Modularize Arcanist settings, let users pick between ambiguous interpretations… (authored by epriestley, committed by epriestley). · Explain WhyNov 23 2016, 9:25 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T12266: arc set-config encoding XXX not work.Feb 15 2017, 11:13 AM

Revision Contents
Changeset List

PathSize
src/
2 lines
browse/
workflow/
46 lines
configuration/
48 lines
12 lines

Diff 40760

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/browse/workflow/ArcanistBrowseWorkflow.php

Loading...
View Options

src/configuration/ArcanistSetting.php

Loading...
View Options

src/configuration/ArcanistSettings.php

Loading...
Phabricator · Built by Phacility