Page MenuHomePhabricator

Modularize Arcanist settings, let users pick between ambiguous interpretations of `arc browse ...`
ClosedPublic

Authored by epriestley on Nov 23 2016, 4:31 PM.
Tags
None
Referenced Files
F12849966: D16928.id.diff
Fri, Mar 29, 5:09 AM
Unknown Object (File)
Tue, Mar 19, 7:12 PM
Unknown Object (File)
Tue, Mar 19, 6:55 PM
Unknown Object (File)
Tue, Mar 19, 6:44 PM
Unknown Object (File)
Feb 19 2024, 1:10 PM
Unknown Object (File)
Feb 19 2024, 12:27 PM
Unknown Object (File)
Feb 17 2024, 3:14 AM
Unknown Object (File)
Feb 3 2024, 1:07 PM
Subscribers
None

Details

Summary

Ref T10895. This modularizes Arcanist settings, but doesn't do anything with them yet.

When users type arc browse X, and only provide one "X", and there are several ways to interpret it, prompt them to choose one.

Test Plan

Created a file named T234, ran arc browse T234, was prompted to interpret it as an object or a path.

Diff Detail

Repository
rARC Arcanist
Branch
xp4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14640
Build 19118: Run Core Tests
Build 19117: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modularize Arcanist settings, let users pick between ambiguous interpretations of `arc browse ...`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2016, 5:02 PM
This revision was automatically updated to reflect the committed changes.