Page MenuHomePhabricator
Differential D16926

Improve PhutilConsole rendering support for ANSI escape sequences
ClosedPublic
Actions

Authored by epriestley on Nov 23 2016, 3:35 PM.
Tags
None
Referenced Files
F14052844: D16926.diff
Fri, Nov 15, 11:09 AM
F14039155: D16926.diff
Mon, Nov 11, 4:06 AM
F14031642: D16926.id40743.diff
Sat, Nov 9, 11:37 AM
F14024189: D16926.diff
Thu, Nov 7, 6:56 AM
F14003867: D16926.diff
Sat, Oct 26, 11:46 AM
F14003685: D16926.diff
Sat, Oct 26, 9:18 AM
F13997619: D16926.diff
Thu, Oct 24, 5:23 AM
F13986562: D16926.id40743.diff
Mon, Oct 21, 3:52 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`
Commits
rPHU683aa2cb4bb4: Improve PhutilConsole rendering support for ANSI escape sequences
Summary

Ref T10895. Currently, if you try to pass tsprintf(...) to this stuff, it gets upset.

Support rendering PhutilTerminalString properly, with indenting/wrapping.

Test Plan

Wrote code with addParagraph(tsprintf(...)) and ran it, saw nice ANSI colors and formatting.

Diff Detail

Repository
rPHU libphutil
Branch
format1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14634
Build 19110: Run Core Tests
Build 19109: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40743.Nov 23 2016, 3:35 PM
epriestley retitled this revision from to Improve PhutilConsole rendering support for ANSI escape sequences.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`.
chad accepted this revision.Nov 23 2016, 3:54 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2016, 3:54 PM
Closed by commit rPHU683aa2cb4bb4: Improve PhutilConsole rendering support for ANSI escape sequences (authored by epriestley, committed by epriestley). · Explain WhyNov 23 2016, 4:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
console/
11 lines
view/
5 lines
3 lines
xsprintf/
12 lines

Diff 40743

View Options

src/console/format.php

Loading...
View Options

src/console/view/PhutilConsoleBlock.php

Loading...
View Options

src/console/view/PhutilConsoleList.php

Loading...
View Options

src/xsprintf/PhutilTerminalString.php

Loading...
Phabricator · Built by Phacility