Page MenuHomePhabricator

Improve PhutilConsole rendering support for ANSI escape sequences
ClosedPublic

Authored by epriestley on Nov 23 2016, 3:35 PM.
Tags
None
Referenced Files
F14408352: D16926.diff
Tue, Dec 24, 4:25 AM
Unknown Object (File)
Thu, Dec 5, 3:22 PM
Unknown Object (File)
Wed, Nov 27, 11:04 AM
Unknown Object (File)
Nov 23 2024, 1:33 PM
Unknown Object (File)
Nov 19 2024, 2:59 AM
Unknown Object (File)
Nov 15 2024, 11:09 AM
Unknown Object (File)
Nov 11 2024, 4:06 AM
Unknown Object (File)
Nov 9 2024, 11:37 AM
Subscribers
None

Details

Summary

Ref T10895. Currently, if you try to pass tsprintf(...) to this stuff, it gets upset.

Support rendering PhutilTerminalString properly, with indenting/wrapping.

Test Plan

Wrote code with addParagraph(tsprintf(...)) and ran it, saw nice ANSI colors and formatting.

Diff Detail

Repository
rPHU libphutil
Branch
format1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14634
Build 19110: Run Core Tests
Build 19109: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Improve PhutilConsole rendering support for ANSI escape sequences.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2016, 3:54 PM
This revision was automatically updated to reflect the committed changes.