Fix an EditEngine issue with unlocking fields which can't be locked
ClosedPublic
Actions

Authored by epriestley on Nov 17 2016, 6:24 PM.

Details

Reviewers

Commits

rP7ebc47d906fe: (stable) Fix an EditEngine issue with unlocking fields which can't be locked
rPd69a1b95e782: Fix an EditEngine issue with unlocking fields which can't be locked

Summary

This code should go inside the field-locking loop. Otherwise, it only applies to the last field, and fatals if there are no fields.

Test Plan

Carefuller inspection.

Diff Detail

Repository

rP Phabricator

Branch

field1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14549
Build 18978: Run Core Tests
Build 18977: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40659.Nov 17 2016, 6:24 PM

epriestley retitled this revision from to Fix an EditEngine issue with unlocking fields which can't be locked.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a subscriber: 20after4.

chad accepted this revision.Nov 17 2016, 6:28 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 17 2016, 6:28 PM

Closed by commit rPd69a1b95e782: Fix an EditEngine issue with unlocking fields which can't be locked (authored by epriestley, committed by epriestley). · Explain WhyNov 17 2016, 6:29 PM

This revision was automatically updated to reflect the committed changes.

hahahah nice.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

storage/

PhabricatorEditEngineConfiguration.php

8 lines

Diff 40659

View Options

src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php

Fix an EditEngine issue with unlocking fields which can't be lockedClosedPublicActions