Page MenuHomePhabricator

Prevent typeahead sources from querying against empty tokens
ClosedPublic

Authored by epriestley on Nov 17 2016, 5:44 PM.
Tags
None
Referenced Files
F14347464: D16888.id40658.diff
Thu, Dec 19, 3:02 AM
F14347463: D16888.id40657.diff
Thu, Dec 19, 3:02 AM
F14347462: D16888.id.diff
Thu, Dec 19, 3:02 AM
F14347456: D16888.diff
Thu, Dec 19, 3:02 AM
Unknown Object (File)
Mon, Dec 9, 8:15 PM
Unknown Object (File)
Fri, Dec 6, 9:39 PM
Unknown Object (File)
Tue, Nov 19, 4:17 PM
Unknown Object (File)
Nov 19 2024, 4:15 AM
Subscribers

Details

Summary

Certain unusual queries, like [-], could tokenize into a list which included the empty string.

This would then convert into a query for ... LIKE "%" which just joins the entire table.

Instead: tokenize smarter; never return the empty token; add some test cases.

Test Plan

Ran unit tests. Queried for [[blah blah]], saw a reasonable query come out the other end.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Prevent typeahead sources from querying against empty tokens.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a subscriber: 20after4.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 17 2016, 5:44 PM
This revision was automatically updated to reflect the committed changes.