Differential D16885

Allow workboard cards to be dragged again by using a larger value for infinity
ClosedPublic
Actions

Authored by epriestley on Nov 17 2016, 12:04 PM.

Details

Reviewers

chad

Maniphest Tasks

T11886: Workboard cards can no longer be dragged between columns

Commits

rPda8c378331e2: Allow workboard cards to be dragged again by using a larger value for infinity

Summary

Fixes T11886. D16882 prevented workboard cards from being dragged between columns because it reduced the effective document height to almost nothing (~78px, just the menu bars).

Instead, use the larger of the document height and viewport height as "infinity".

Test Plan

Dragged columns between workboards successfully.

Diff Detail

Repository

rP Phabricator

Branch

drag1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14540
Build 18965: Run Core Tests
Build 18964: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40651.Nov 17 2016, 12:04 PM

epriestley retitled this revision from to Allow workboard cards to be dragged again by using a larger value for infinity.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11886: Workboard cards can no longer be dragged between columns.

Whoops

This revision is now accepted and ready to land.Nov 17 2016, 2:42 PM

Closed by commit rPda8c378331e2: Allow workboard cards to be dragged again by using a larger value for infinity (authored by epriestley, committed by epriestley). · Explain WhyNov 17 2016, 4:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

22 lines

webroot/

rsrc/

js/

core/

DraggableList.js

9 lines

Diff 40651

View Options

resources/celerity/map.php