Remove sidenav from Workboards
ClosedPublic
Actions

Authored by chad on Nov 16 2016, 6:20 PM.

Details

Reviewers

epriestley

Commits

rPd2f3e7f7f3ab: Remove sidenav from Workboards

Summary

Visually, I think these are much cleaner (with colors), and provide more workspace. I also don't really use the sidenav here and if I did, it would be to go back to the project homepage. I think this is overall better. If navigation page to project home is difficult or hard to find, we can maybe make a better header / crumbs bar to reduce that.

Test Plan

New project -> basic new board. Existing project -> color board. Desktop, Mobile, Fullscreen

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 40644.Nov 16 2016, 6:20 PM

chad retitled this revision from to Remove sidenav from Workboards.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptNov 16 2016, 6:20 PM

always return profile uri

epriestley accepted this revision.Nov 17 2016, 12:34 AM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/project/controller/PhabricatorProjectController.php
122–123	Add a `getProfileURI()` to `PhabricatorProject` instead? (Avoid calling methods inside strings; this pathway leads to madness.)

This revision is now accepted and ready to land.Nov 17 2016, 12:34 AM

Closed by commit rPd2f3e7f7f3ab: Remove sidenav from Workboards (authored by chad, committed by chad). · Explain WhyNov 17 2016, 12:43 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T11886: Workboard cards can no longer be dragged between columns.Nov 17 2016, 11:33 AM

epriestley mentioned this in D16885: Allow workboard cards to be dragged again by using a larger value for infinity.Nov 17 2016, 12:04 PM

epriestley mentioned this in rPda8c378331e2: Allow workboard cards to be dragged again by using a larger value for infinity.Nov 17 2016, 4:02 PM

We use the workboard as the default page for our projects and as such were using the side-menu for quick navigation to various items (Phriction page link, specific tag filters for the workboard for example). Is there any way this change could become optional using the settings?

We also used links in the sidebar to quickly filter by team/tag.

Like so:
/project/board/5/query/HIpzLiC1CLjg/
/project/board/5/query/XKElxaLcdR.V/

Can this please be made an option? Or suggestions for alternate ways to accomplish this would be welcome.