Page MenuHomePhabricator

Fix an issue where All Day events could return a DateTime with the wrong timezone
ClosedPublic

Authored by epriestley on Nov 16 2016, 3:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 1:39 AM
Unknown Object (File)
Fri, Apr 19, 5:41 PM
Unknown Object (File)
Thu, Apr 11, 9:28 AM
Unknown Object (File)
Fri, Apr 5, 1:18 PM
Unknown Object (File)
Mar 31 2024, 9:24 AM
Unknown Object (File)
Mar 30 2024, 3:04 AM
Unknown Object (File)
Mar 28 2024, 8:47 PM
Unknown Object (File)
Mar 28 2024, 7:53 AM
Subscribers
None

Details

Summary

Ref T11816. When building a PHP DateTime object, we favored the DateTime's timezone over the viewer's timezone, even for all-day dates.

This is incorrect: we should return all-day dates in the viewer's timezone, since otherwise the display layer will adjust them to the "correct" timezone.

Now non-all-day dates retain the old logic; all-day dates favor the viewer's timezone.

This only meaningfully affected display stuff since all the epoch logic was already correct.

Test Plan

Created an all day event, changed timezone forward/backward, observed dates still rendering correctly in tooltips and subheaders.

Diff Detail

Repository
rPHU libphutil
Branch
vzone1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14524
Build 18942: Run Core Tests
Build 18941: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix an issue where All Day events could return a DateTime with the wrong timezone.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 16 2016, 3:30 PM
This revision was automatically updated to reflect the committed changes.