Fix an issue with generating browser URIs in an SVN repository
ClosedPublic
Actions

Authored by epriestley on Nov 15 2016, 2:53 PM.

Details

Reviewers

chad

Maniphest Tasks

T11866: PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument

Commits

rPe6c82c099481: Fix an issue with generating browser URIs in an SVN repository

Summary

Fixes T11866. This got converted wrong when doing the /source/ stuff.

Test Plan

Browsed the root directory of a Subversion repository in Diffusion.

Diff Detail

Repository

rP Phabricator

Branch

repo1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14489
Build 18890: Run Core Tests
Build 18889: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40599.Nov 15 2016, 2:53 PM

epriestley retitled this revision from to Fix an issue with generating browser URIs in an SVN repository.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11866: PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument.

chad accepted this revision.Nov 15 2016, 3:13 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 15 2016, 3:13 PM

Closed by commit rPe6c82c099481: Fix an issue with generating browser URIs in an SVN repository (authored by epriestley, committed by epriestley). · Explain WhyNov 15 2016, 3:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

storage/

PhabricatorRepository.php

2 lines

Diff 40599

View Options

src/applications/repository/storage/PhabricatorRepository.php

Fix an issue with generating browser URIs in an SVN repositoryClosedPublicActions