Differential D16842

Give more space for new select dropdown image
ClosedPublic
Actions

Authored by chad on Nov 11 2016, 9:36 PM.

Details

Reviewers

epriestley

Commits

rP32d2955f22cf: Give more space for new select dropdown image

Summary

On really wide selects, text will go over the background image. Give it more padding.

Test Plan

Review selects on email preferences page.

Diff Detail

Repository

rP Phabricator

Branch

select-padding (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14446
Build 18829: Run Core Tests
Build 18828: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40555.Nov 11 2016, 9:36 PM

chad retitled this revision from to Give more space for new select dropdown image.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptNov 11 2016, 9:36 PM

epriestley accepted this revision.Nov 11 2016, 9:41 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 11 2016, 9:41 PM

Closed by commit rP32d2955f22cf: Give more space for new select dropdown image (authored by chad, committed by chad). · Explain WhyNov 11 2016, 9:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

phui-form.css

2 lines

Diff 40555

View Options

resources/celerity/map.php