Page MenuHomePhabricator
Differential D16819

On `@username` mentions in remarkup, show the "busy" dot color
ClosedPublic
Actions

Authored by epriestley on Nov 7 2016, 8:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 10, 3:00 AM
Unknown Object (File)
Mon, May 5, 3:20 PM
Unknown Object (File)
Mon, Apr 28, 5:36 PM
Unknown Object (File)
Sun, Apr 27, 11:57 PM
Unknown Object (File)
Sat, Apr 26, 5:37 PM
Unknown Object (File)
Sat, Apr 26, 11:15 AM
Unknown Object (File)
Apr 11 2025, 3:12 PM
Unknown Object (File)
Apr 10 2025, 10:31 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11809: Calendar v1 Errata Mark II
Commits
rP6a7dde03ccfb: On `@username` mentions in remarkup, show the "busy" dot color
Summary

Ref T11809. I missed this when adding a "Busy" status.

Also the other dot is orange? Just make them all orange for consistency.

Test Plan

Viewed @username of busy users (orange), away users (red).

Diff Detail

Repository
rP Phabricator
Branch
mention1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14390
Build 18741: Run Core Tests
Build 18740: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40499.Nov 7 2016, 8:26 PM
epriestley retitled this revision from to On `@username` mentions in remarkup, show the "busy" dot color.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11809: Calendar v1 Errata Mark II.
epriestley mentioned this in T11816: Calendar: Feedback and Suggestions.Nov 7 2016, 8:40 PM
chad edited edge metadata.Nov 7 2016, 8:49 PM

the image dot looks like ass.

chad accepted this revision.Nov 7 2016, 8:50 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 7 2016, 8:50 PM
chad added a comment.Nov 7 2016, 8:50 PM

if only you could draw a circle in CSS

epriestley added a comment.Nov 7 2016, 8:58 PM

Computers just can't do that.

chad added a comment.Nov 7 2016, 8:59 PM

I cheat with font-awesome

chad added a comment.Nov 7 2016, 8:59 PM

that's a circle you can set your watch to.

Closed by commit rP6a7dde03ccfb: On `@username` mentions in remarkup, show the "busy" dot color (authored by epriestley, committed by epriestley). · Explain WhyNov 7 2016, 10:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
storage/
2 lines
people/
markup/
7 lines

Diff 40499

View Options

src/applications/calendar/storage/PhabricatorCalendarEventInvitee.php

Loading...
View Options

src/applications/people/markup/PhabricatorMentionRemarkupRule.php

Loading...
Phabricator · Built by Phacility