Page MenuHomePhabricator
Differential D16818

Allow transactions to specialize their mail headers for diff sections
ClosedPublic
Actions

Authored by epriestley on Nov 7 2016, 7:39 PM.
Tags
None
Referenced Files
F14053391: D16818.diff
Fri, Nov 15, 3:14 PM
F14039221: D16818.diff
Mon, Nov 11, 4:31 AM
F14030077: D16818.id40498.diff
Fri, Nov 8, 11:48 PM
F14023133: D16818.diff
Wed, Nov 6, 11:00 PM
F14013526: D16818.id40498.diff
Sat, Nov 2, 7:33 AM
F13985205: D16818.diff
Sun, Oct 20, 6:46 PM
F13981481: D16818.id40497.diff
Sat, Oct 19, 4:50 PM
Unknown Object (File)
Oct 9 2024, 6:06 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T7643: Improve prose diffs (was: description changes don't generate usable diffs)
Commits
rP729492a8ff85: Allow transactions to specialize their mail headers for diff sections
Summary

Ref T7643. When we send mail about a change to a package description, allow it to say "CHANGES TO PACKAGE DESCRIPTION" instead of "EDIT DETAILS". Smooth!

Test Plan

Screen Shot 2016-11-07 at 11.33.55 AM.png (284×864 px, 36 KB)

Diff Detail

Repository
rP Phabricator
Branch
oldnew2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14388
Build 18738: Run Core Tests
Build 18737: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40497.Nov 7 2016, 7:39 PM
epriestley retitled this revision from to Allow transactions to specialize their mail headers for diff sections.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T7643: Improve prose diffs (was: description changes don't generate usable diffs).
chad accepted this revision.Nov 7 2016, 7:42 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 7 2016, 7:42 PM
Closed by commit rP729492a8ff85: Allow transactions to specialize their mail headers for diff sections (authored by epriestley, committed by epriestley). · Explain WhyNov 7 2016, 8:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40497

View Options

src/applications/calendar/xaction/PhabricatorCalendarEventDescriptionTransaction.php

Loading...
View Options

src/applications/owners/xaction/PhabricatorOwnersPackageDescriptionTransaction.php

Loading...
View Options

src/applications/paste/xaction/PhabricatorPasteContentTransaction.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorModularTransactionType.php

Loading...
Phabricator · Built by Phacility