Page MenuHomePhabricator

In Maniphest, don't render the task graph drawing if we're only showing parents/children
ClosedPublic

Authored by epriestley on Nov 7 2016, 7:08 PM.
Tags
None
Referenced Files
F14058012: D16816.diff
Sun, Nov 17, 8:44 AM
F14056030: D16816.id40494.diff
Sat, Nov 16, 5:39 PM
F14040390: D16816.id40494.diff
Mon, Nov 11, 9:47 AM
F14038860: D16816.id40494.diff
Mon, Nov 11, 2:30 AM
F14030689: D16816.id.diff
Sat, Nov 9, 5:20 AM
F14030668: D16816.id40495.diff
Sat, Nov 9, 5:00 AM
F14030114: D16816.diff
Sat, Nov 9, 12:08 AM
F14029755: D16816.diff
Fri, Nov 8, 9:13 PM
Subscribers
None

Details

Summary

Ref T4788. I thought I implemented this, but actualy didn't.

When we're in the "mid-sized" fallback mode (graph has more than 100 nodes, but not more than than 100 parents/children), don't actually draw the graph. It's almost always uninteresting and huge.

Instead, this just renders a list of direct parents, then the task, then the direct children, which is pretty straightforward.

Test Plan

Set limit to 5, saw mid-sized fallback graph with no actual graph drawing.

Diff Detail

Repository
rP Phabricator
Branch
graph1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14385
Build 18733: Run Core Tests
Build 18732: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to In Maniphest, don't render the task graph drawing if we're only showing parents/children.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 7 2016, 7:09 PM
This revision was automatically updated to reflect the committed changes.