Page MenuHomePhabricator

In Maniphest, don't render the task graph drawing if we're only showing parents/children
ClosedPublic

Authored by epriestley on Nov 7 2016, 7:08 PM.
Tags
None
Referenced Files
F15444655: D16816.diff
Thu, Mar 27, 10:36 AM
F15429570: D16816.id40494.diff
Mon, Mar 24, 2:59 AM
F15428694: D16816.diff
Sun, Mar 23, 9:46 PM
F15397594: D16816.id40494.diff
Sun, Mar 16, 9:15 PM
F15386278: D16816.id40494.diff
Mar 15 2025, 12:16 AM
F15337279: D16816.diff
Mar 9 2025, 5:09 AM
F15336750: D16816.id40494.diff
Mar 9 2025, 1:13 AM
F15283966: D16816.diff
Mar 4 2025, 8:59 AM
Subscribers
None

Details

Summary

Ref T4788. I thought I implemented this, but actualy didn't.

When we're in the "mid-sized" fallback mode (graph has more than 100 nodes, but not more than than 100 parents/children), don't actually draw the graph. It's almost always uninteresting and huge.

Instead, this just renders a list of direct parents, then the task, then the direct children, which is pretty straightforward.

Test Plan

Set limit to 5, saw mid-sized fallback graph with no actual graph drawing.

Diff Detail

Repository
rP Phabricator
Branch
graph1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14385
Build 18733: Run Core Tests
Build 18732: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to In Maniphest, don't render the task graph drawing if we're only showing parents/children.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 7 2016, 7:09 PM
This revision was automatically updated to reflect the committed changes.