Differential D16813

When converting an absolute datetime to an absolute datetime, just clone it
ClosedPublic
Actions

Authored by epriestley on Nov 7 2016, 6:40 PM.

Details

Reviewers

chad

Maniphest Tasks

T11801: Calendar: ICS Import Errata

Commits

rPHU77c4e8b7c77e: When converting an absolute datetime to an absolute datetime, just clone it

Summary

Ref T11801. Previously, we would go through the generic implementation which incorrectly tagged all-day datetimes as UTC.

Test Plan

Imported a French holiday. See next changes.

Diff Detail

Repository

rPHU libphutil

Branch

cal1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14379
Build 18724: Run Core Tests
Build 18723: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40488.Nov 7 2016, 6:40 PM

epriestley retitled this revision from to When converting an absolute datetime to an absolute datetime, just clone it.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11801: Calendar: ICS Import Errata.

Imported a French holiday.

c'est la vie

chad accepted this revision.Nov 7 2016, 6:41 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 7 2016, 6:41 PM

For reference:

french-holiday.ics428 BDownload

Closed by commit rPHU77c4e8b7c77e: When converting an absolute datetime to an absolute datetime, just clone it (authored by epriestley, committed by epriestley). · Explain WhyNov 7 2016, 6:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

data/

PhutilCalendarAbsoluteDateTime.php

5 lines

Diff 40488

View Options

src/parser/calendar/data/PhutilCalendarAbsoluteDateTime.php

When converting an absolute datetime to an absolute datetime, just clone itClosedPublicActions