Page MenuHomePhabricator
Differential D16809

Fix a minor i18n issue in libphutil
ClosedPublic
Actions

Authored by epriestley on Nov 6 2016, 7:19 PM.
Tags
None
Referenced Files
F13314723: D16809.id40484.diff
Tue, Jun 11, 11:40 PM
F13301262: D16809.diff
Fri, Jun 7, 5:12 PM
F13257358: D16809.id.diff
Sat, May 25, 11:41 PM
F13206574: D16809.id.diff
May 15 2024, 12:11 PM
F13206573: D16809.id40484.diff
May 15 2024, 12:11 PM
F13206572: D16809.id40479.diff
May 15 2024, 12:11 PM
F13192217: D16809.id40484.diff
May 12 2024, 6:21 AM
F13180860: D16809.diff
May 9 2024, 4:39 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T5267: Localize Phabricator
Commits
rPHUbf430206c8a9: Fix a minor i18n issue in libphutil
Summary

Ref T5267. Fixes a missing %s.

Also ignores the src/.cache/ directory, used for the i18n cache.

Test Plan

Extracted strings more cleanly.

Diff Detail

Repository
rPHU libphutil
Branch
i18n3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14371
Build 18713: Run Core Tests
Build 18712: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40479.Nov 6 2016, 7:19 PM
epriestley retitled this revision from to Fix a minor i18n issue in libphutil.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T5267: Localize Phabricator.
chad accepted this revision.Nov 6 2016, 8:59 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 6 2016, 8:59 PM
Closed by commit rPHUbf430206c8a9: Fix a minor i18n issue in libphutil (authored by epriestley, committed by epriestley). · Explain WhyNov 7 2016, 5:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
1 line
src/
aphront/
writeguard/
2 lines

Diff 40479

View Options

.gitignore

Loading...
View Options

src/aphront/writeguard/AphrontWriteGuard.php

Loading...
Phabricator · Built by Phacility