Page MenuHomePhabricator
Differential D16809

Fix a minor i18n issue in libphutil
ClosedPublic
Actions

Authored by epriestley on Nov 6 2016, 7:19 PM.
Tags
None
Referenced Files
F14090046: D16809.diff
Sun, Nov 24, 3:17 PM
Unknown Object (File)
Wed, Nov 20, 5:43 PM
Unknown Object (File)
Sat, Nov 16, 4:08 AM
Unknown Object (File)
Tue, Nov 12, 2:27 AM
Unknown Object (File)
Fri, Nov 8, 9:18 PM
Unknown Object (File)
Fri, Nov 8, 9:03 AM
Unknown Object (File)
Mon, Nov 4, 2:21 PM
Unknown Object (File)
Mon, Nov 4, 2:18 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T5267: Localize Phabricator
Commits
rPHUbf430206c8a9: Fix a minor i18n issue in libphutil
Summary

Ref T5267. Fixes a missing %s.

Also ignores the src/.cache/ directory, used for the i18n cache.

Test Plan

Extracted strings more cleanly.

Diff Detail

Repository
rPHU libphutil
Branch
i18n3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14371
Build 18713: Run Core Tests
Build 18712: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40479.Nov 6 2016, 7:19 PM
epriestley retitled this revision from to Fix a minor i18n issue in libphutil.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T5267: Localize Phabricator.
chad accepted this revision.Nov 6 2016, 8:59 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 6 2016, 8:59 PM
Closed by commit rPHUbf430206c8a9: Fix a minor i18n issue in libphutil (authored by epriestley, committed by epriestley). · Explain WhyNov 7 2016, 5:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
1 line
src/
aphront/
writeguard/
2 lines

Diff 40479

View Options

.gitignore

Loading...
View Options

src/aphront/writeguard/AphrontWriteGuard.php

Loading...
Phabricator · Built by Phacility