Page MenuHomePhabricator
Differential D16795

Improve some commenting/editing behaviors for recurring events
ClosedPublic
Actions

Authored by epriestley on Nov 2 2016, 8:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 3, 10:40 AM
Unknown Object (File)
Fri, Dec 27, 10:38 PM
Unknown Object (File)
Fri, Dec 27, 4:56 PM
Unknown Object (File)
Thu, Dec 26, 6:56 PM
Unknown Object (File)
Dec 12 2024, 2:15 PM
Unknown Object (File)
Dec 1 2024, 5:32 PM
Unknown Object (File)
Nov 28 2024, 3:13 AM
Unknown Object (File)
Nov 27 2024, 12:17 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11809: Calendar v1 Errata Mark II
Commits
rP29313372e715: Improve some commenting/editing behaviors for recurring events
Summary

Ref T11809. Currently, commenting on a recurring event hits the same "one or all?" dialog that other edits do.

For comments and edits submitted via the comment widget, we can safely assume that you mean "just this one", since it doesn't really make sense to try to bulk-edit an event from that UI.

Test Plan

Commented on a recurring event parent and an event in the series.

Diff Detail

Repository
rP Phabricator
Branch
cal4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14337
Build 18665: Run Core Tests
Build 18664: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40447.Nov 2 2016, 8:44 PM
epriestley retitled this revision from to Improve some commenting/editing behaviors for recurring events.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11809: Calendar v1 Errata Mark II.
chad accepted this revision.Nov 2 2016, 9:08 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 2 2016, 9:08 PM
Closed by commit rP29313372e715: Improve some commenting/editing behaviors for recurring events (authored by epriestley, committed by epriestley). · Explain WhyNov 2 2016, 9:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40447

View Options

src/applications/calendar/controller/PhabricatorCalendarEventEditController.php

Loading...
View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditEngine.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventReplyTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventTransactionType.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
Phabricator · Built by Phacility