Paths

Table of Contentst

Differential D16794

In Calendar, only include the event description in the original event mail
ClosedPublic
Actions

Authored by epriestley on Nov 2 2016, 8:12 PM.

Details

Reviewers

chad

Maniphest Tasks

T11809: Calendar v1 Errata Mark II

Commits

rP64cf9204c1d9: In Calendar, only include the event description in the original event mail

Summary

Ref T11809. This makes the mail more consistent with Differential and Maniphest, which only include additional details in the first mail in the thread.

Test Plan

Created an event with a description.
First mail included it.
Followups did not.

Diff Detail

Repository

rP Phabricator

Branch

cal3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14334
Build 18660: Run Core Tests
Build 18659: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40444.Nov 2 2016, 8:12 PM

epriestley retitled this revision from to In Calendar, only include the event description in the original event mail.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11809: Calendar v1 Errata Mark II.

Also, use "getMonogram()", "getURI()" more consistently instead of manually building "E" + id.

chad accepted this revision.Nov 2 2016, 8:25 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 2 2016, 8:25 PM

Closed by commit rP64cf9204c1d9: In Calendar, only include the event description in the original event mail (authored by epriestley, committed by epriestley). · Explain WhyNov 2 2016, 8:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

editor/

PhabricatorCalendarEventEditor.php

12 lines

Diff 40444

View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

In Calendar, only include the event description in the original event mailClosedPublicActions