Differential D16793

Fix a bug which could cause imported events to set themselves as their own parents
ClosedPublic
Actions

Authored by epriestley on Nov 2 2016, 6:34 PM.

Details

Reviewers

chad

Maniphest Tasks

T11808: Calendar has cursor paging issue on import sources

Commits

rP713f8fb373e4: Fix a bug which could cause imported events to set themselves as their own…

Summary

Ref T11808. This variable is wrong, and would sometimes cause events to set themsevles as their own parents. They would then fail to load, and disrupt cursor paging.

Test Plan

Reproduced T11808 locally by reloading test data 2+ times, creating events with themselves as their own parents.
Appplied fix.
Nuked data, reloaded, no more self-parents.
Test datafile:
T11808.ics5 KBDownload

Diff Detail

Repository

rP Phabricator

Branch

cal3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14332
Build 18657: Run Core Tests
Build 18656: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40442.Nov 2 2016, 6:34 PM

epriestley retitled this revision from to Fix a bug which could cause imported events to set themselves as their own parents.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11808: Calendar has cursor paging issue on import sources.

chad accepted this revision.Nov 2 2016, 6:43 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 2 2016, 6:43 PM

Closed by commit rP713f8fb373e4: Fix a bug which could cause imported events to set themselves as their own… (authored by epriestley, committed by epriestley). · Explain WhyNov 2 2016, 6:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

import/

PhabricatorCalendarImportEngine.php

2 lines

Diff 40442

View Options

src/applications/calendar/import/PhabricatorCalendarImportEngine.php

Fix a bug which could cause imported events to set themselves as their own parentsClosedPublicActions