Page MenuHomePhabricator

Move "Calendar" above "Badges" on user profiles
ClosedPublic

Authored by epriestley on Nov 2 2016, 4:53 PM.
Tags
None
Referenced Files
F13995145: D16790.id40438.diff
Wed, Oct 23, 10:54 AM
F13979613: D16790.id40445.diff
Sat, Oct 19, 5:27 AM
Unknown Object (File)
Oct 13 2024, 4:06 AM
Unknown Object (File)
Oct 2 2024, 2:16 AM
Unknown Object (File)
Sep 30 2024, 6:07 PM
Unknown Object (File)
Sep 23 2024, 9:59 PM
Unknown Object (File)
Sep 13 2024, 8:32 AM
Unknown Object (File)
Sep 13 2024, 8:32 AM
Subscribers
None

Details

Summary

Ref T11809. As we move toward unprototyping, this panel is probably more relevant/dynamic/interesting more often than the badges panel, I think?

Particularly, I want to make the red dots a little easier to understand, and I think putting this above the fold will help aid discovery (red dot -> click -> see red dot -> see "away until ..." -> see calendar -> "oh they're at a meeting"?).

This is entirely a product/subjective thing so I'm fine with not doing it or using a different order.

I think there's maybe even an argument for putting this above "Projects", but "Projects" feels more core to me, at least for now.

Test Plan

Viewed a user profile, saw "Calendar" above "Badges".

Diff Detail

Repository
rP Phabricator
Branch
cal1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14328
Build 18649: Run Core Tests
Build 18648: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Move "Calendar" above "Badges" on user profiles.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 2 2016, 8:00 PM
This revision was automatically updated to reflect the committed changes.