Page MenuHomePhabricator

Remove ancient "Holiday" storage
ClosedPublic

Authored by epriestley on Nov 1 2016, 10:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 1:39 AM
Unknown Object (File)
Wed, Nov 27, 10:54 AM
Unknown Object (File)
Fri, Nov 22, 10:31 PM
Unknown Object (File)
Tue, Nov 19, 8:42 AM
Unknown Object (File)
Nov 15 2024, 1:56 AM
Unknown Object (File)
Nov 11 2024, 12:00 PM
Unknown Object (File)
Nov 7 2024, 7:27 AM
Unknown Object (File)
Oct 21 2024, 1:33 PM
Subscribers
None

Details

Summary

Ref T11809. This came out of Facebook many years ago for computing the number of business days that revisions had been stale.

We removed the little staleness marker a few months ago and haven't seen complaints about it.

If we did holidays now it would make sense to integrate them more directly with Calendar as real events, but I have no plans to pursue this anytime soon. It's easy enough to add the federal holidays manually (~5 minutes of work per year?) if you want them, and they're commentable/editable and you can add local holidays if you're not in the US.

Test Plan
  • Ran bin/storage upgrade -f.
  • Grepped for CalendarHoliday.

Diff Detail

Repository
rP Phabricator
Branch
cal1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14324
Build 18643: Run Core Tests
Build 18642: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Remove ancient "Holiday" storage.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 1 2016, 10:55 PM
This revision was automatically updated to reflect the committed changes.