Page MenuHomePhabricator
Differential D16786

Store more datetime information on Calendar transactions and improve rendering behaviors
ClosedPublic
Actions

Authored by epriestley on Nov 1 2016, 8:22 PM.
Tags
None
Referenced Files
F15508880: D16786.diff
Wed, Apr 16, 6:55 AM
F15506280: D16786.diff
Tue, Apr 15, 9:55 AM
F15492024: D16786.id40426.diff
Sat, Apr 12, 9:55 AM
F15486064: D16786.diff
Thu, Apr 10, 4:39 AM
F15480376: D16786.id.diff
Tue, Apr 8, 1:49 PM
F15459433: D16786.id40426.diff
Mon, Mar 31, 12:55 PM
F15451355: D16786.id.diff
Fri, Mar 28, 9:41 PM
F15447493: D16786.diff
Fri, Mar 28, 12:12 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11805: Use PhutilCalendarDateTime or similar for internal Calendar date-time transactions
Commits
rP3e15e0b9806b: Store more datetime information on Calendar transactions and improve rendering…
Summary

Fixes T11805. Depends on D16785. This generally tries to smooth out transactions:

  • All-day stuff now says "Nov 3" instead of "Nov 3 12:00:00 AM".
  • Fewer weird bugs / extra transactions.
  • No more silly extra "yeah, you definitely set that event time" transaction on create.
Test Plan

Edited events; changed from all-day to not-all-day and back again, viewed transaction log.

Diff Detail

Repository
rP Phabricator
Branch
calendar12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14316
Build 18631: Run Core Tests
Build 18630: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40426.Nov 1 2016, 8:22 PM
epriestley retitled this revision from to Store more datetime information on Calendar transactions and improve rendering behaviors.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11805: Use PhutilCalendarDateTime or similar for internal Calendar date-time transactions.
epriestley added a parent revision: D16785: Add some stricter casts to PhutilCalendarAbsoluteDateTime serialization.
chad accepted this revision.Nov 1 2016, 8:34 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 1 2016, 8:34 PM
Closed by commit rP3e15e0b9806b: Store more datetime information on Calendar transactions and improve rendering… (authored by epriestley, committed by epriestley). · Explain WhyNov 1 2016, 8:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40426

View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventDateTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventEndDateTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventStartDateTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventUntilDateTransaction.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorModularTransactionType.php

Loading...
View Options

src/view/form/control/AphrontFormDateControlValue.php

Loading...
Phabricator · Built by Phacility