Differential D16785

Add some stricter casts to PhutilCalendarAbsoluteDateTime serialization
ClosedPublic
Actions

Authored by epriestley on Nov 1 2016, 8:07 PM.

Details

Reviewers

chad

Maniphest Tasks

T11805: Use PhutilCalendarDateTime or similar for internal Calendar date-time transactions

Commits

rPHU2b7b1007bf87: Add some stricter casts to PhutilCalendarAbsoluteDateTime serialization

Summary

Ref T11805. This fixes a future issue with comparing edited values: false and 0 were being considered to be an edit.

Test Plan

See next change.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40425.Nov 1 2016, 8:07 PM

epriestley retitled this revision from to Add some stricter casts to PhutilCalendarAbsoluteDateTime serialization.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11805: Use PhutilCalendarDateTime or similar for internal Calendar date-time transactions.

chad accepted this revision.Nov 1 2016, 8:08 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 1 2016, 8:08 PM

epriestley added a child revision: D16786: Store more datetime information on Calendar transactions and improve rendering behaviors.Nov 1 2016, 8:22 PM

Closed by commit rPHU2b7b1007bf87: Add some stricter casts to PhutilCalendarAbsoluteDateTime serialization (authored by epriestley, committed by epriestley). · Explain WhyNov 1 2016, 8:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

data/

PhutilCalendarAbsoluteDateTime.php

16 lines

Diff 40427

View Options

src/parser/calendar/data/PhutilCalendarAbsoluteDateTime.php

Add some stricter casts to PhutilCalendarAbsoluteDateTime serializationClosedPublicActions