Page MenuHomePhabricator
Differential D16785

Add some stricter casts to PhutilCalendarAbsoluteDateTime serialization
ClosedPublic
Actions

Authored by epriestley on Nov 1 2016, 8:07 PM.
Tags
None
Referenced Files
F14077286: D16785.diff
Thu, Nov 21, 10:25 PM
F14073136: D16785.id40425.diff
Wed, Nov 20, 11:04 PM
Unknown Object (File)
Tue, Nov 19, 10:13 PM
Unknown Object (File)
Sat, Nov 16, 11:31 AM
Unknown Object (File)
Tue, Nov 12, 3:48 AM
Unknown Object (File)
Fri, Nov 8, 7:03 AM
Unknown Object (File)
Oct 22 2024, 9:18 AM
Unknown Object (File)
Oct 22 2024, 9:16 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11805: Use PhutilCalendarDateTime or similar for internal Calendar date-time transactions
Commits
rPHU2b7b1007bf87: Add some stricter casts to PhutilCalendarAbsoluteDateTime serialization
Summary

Ref T11805. This fixes a future issue with comparing edited values: false and 0 were being considered to be an edit.

Test Plan

See next change.

Diff Detail

Repository
rPHU libphutil
Branch
cal4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14315
Build 18629: Run Core Tests
Build 18628: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40425.Nov 1 2016, 8:07 PM
epriestley retitled this revision from to Add some stricter casts to PhutilCalendarAbsoluteDateTime serialization.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11805: Use PhutilCalendarDateTime or similar for internal Calendar date-time transactions.
chad accepted this revision.Nov 1 2016, 8:08 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 1 2016, 8:08 PM
epriestley added a child revision: D16786: Store more datetime information on Calendar transactions and improve rendering behaviors.Nov 1 2016, 8:22 PM
Closed by commit rPHU2b7b1007bf87: Add some stricter casts to PhutilCalendarAbsoluteDateTime serialization (authored by epriestley, committed by epriestley). · Explain WhyNov 1 2016, 8:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
calendar/
data/
16 lines

Diff 40425

View Options

src/parser/calendar/data/PhutilCalendarAbsoluteDateTime.php

Loading...
Phabricator · Built by Phacility