Page MenuHomePhabricator

When users edit recurring events, prompt to "Edit This Event" or "Edit All Future Events"
ClosedPublic

Authored by epriestley on Oct 31 2016, 10:18 PM.
Tags
None
Referenced Files
F12829982: D16782.diff
Thu, Mar 28, 11:52 AM
Unknown Object (File)
Tue, Mar 5, 10:31 AM
Unknown Object (File)
Feb 12 2024, 3:26 PM
Unknown Object (File)
Jan 24 2024, 7:57 AM
Unknown Object (File)
Jan 13 2024, 8:44 PM
Unknown Object (File)
Jan 2 2024, 6:15 AM
Unknown Object (File)
Jan 2 2024, 6:15 AM
Unknown Object (File)
Dec 25 2023, 4:37 PM
Subscribers
None

Details

Summary

Fixes T11804. This probably isn't perfect but seems to work fairly reasonably and not be as much of a weird nonsense mess like the old behavior was.

When a user edits a recurring event, we ask them what they're trying to do. Then we more or less do that.

Test Plan
  • Edited an event in the middle of a series.
  • Edited the first event in a series.
  • Edited "just this" and "all future" events in various places in a series.
  • Edited normal events.
  • Cancelled various events.

Diff Detail

Repository
rP Phabricator
Branch
calendar9
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/calendar/editor/PhabricatorCalendarEventEditEngine.php:351XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 14306
Build 18616: Run Core Tests
Build 18615: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to When users edit recurring events, prompt to "Edit This Event" or "Edit All Future Events".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.

tldr;

This revision is now accepted and ready to land.Oct 31 2016, 11:01 PM

i mean, I didn't see stealCorporateSecrets or anything

This revision was automatically updated to reflect the committed changes.