Page MenuHomePhabricator

Make the "All Day Event" control use a checkbox instead of a dropdown
ClosedPublic

Authored by epriestley on Oct 31 2016, 6:41 PM.
Tags
None
Referenced Files
F13130104: D16776.diff
Wed, May 1, 6:16 AM
Unknown Object (File)
Thu, Apr 25, 4:30 PM
Unknown Object (File)
Tue, Apr 16, 5:08 AM
Unknown Object (File)
Fri, Apr 12, 9:09 PM
Unknown Object (File)
Fri, Apr 12, 9:09 PM
Unknown Object (File)
Fri, Apr 12, 9:03 PM
Unknown Object (File)
Fri, Apr 12, 8:18 PM
Unknown Object (File)
Mon, Apr 8, 12:37 AM
Subscribers
None

Details

Summary

This feels a little cleaner:

  • Clean up transaction log a bit.
  • Use a checkbox instead of a two-option dropdown.

This is a little messy because the browser doesn't send anything if the user submits a form with an un-clicked checkbox.

We now send a dummy value ("Hey, there's definitely a checkbox in this form!") so the server can figure out what to do.

Test Plan
  • Edited all-dayness of an event.
  • Viewed transaction log.

Diff Detail

Repository
rP Phabricator
Branch
calendar3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14294
Build 18597: Run Core Tests
Build 18596: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Make the "All Day Event" control use a checkbox instead of a dropdown.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 31 2016, 7:20 PM
This revision was automatically updated to reflect the committed changes.