Page MenuHomePhabricator

Make the "All Day Event" control use a checkbox instead of a dropdown
ClosedPublic

Authored by epriestley on Oct 31 2016, 6:41 PM.
Tags
None
Referenced Files
F14031584: D16776.id40404.diff
Sat, Nov 9, 11:29 AM
F14013360: D16776.id40412.diff
Sat, Nov 2, 5:00 AM
F13985083: D16776.diff
Sun, Oct 20, 5:57 PM
F13978477: D16776.id40404.diff
Oct 18 2024, 11:23 PM
Unknown Object (File)
Sep 29 2024, 6:09 PM
Unknown Object (File)
Sep 26 2024, 9:43 AM
Unknown Object (File)
Sep 22 2024, 3:35 AM
Unknown Object (File)
Sep 21 2024, 5:42 AM
Subscribers
None

Details

Summary

This feels a little cleaner:

  • Clean up transaction log a bit.
  • Use a checkbox instead of a two-option dropdown.

This is a little messy because the browser doesn't send anything if the user submits a form with an un-clicked checkbox.

We now send a dummy value ("Hey, there's definitely a checkbox in this form!") so the server can figure out what to do.

Test Plan
  • Edited all-dayness of an event.
  • Viewed transaction log.

Diff Detail

Repository
rP Phabricator
Branch
calendar3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14294
Build 18597: Run Core Tests
Build 18596: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Make the "All Day Event" control use a checkbox instead of a dropdown.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 31 2016, 7:20 PM
This revision was automatically updated to reflect the committed changes.