Fix some extra "changed the start time of this event" transactions
ClosedPublic
Actions

Authored by epriestley on Oct 30 2016, 4:17 PM.

Details

Reviewers

chad

Maniphest Tasks

T11326: Improve Calendar v1 Design/UI/UX

Commits

rP5e784c998bae: Fix some extra "changed the start time of this event" transactions

Summary

Ref T11326. Since we were missing an (int) cast here, the code ended up thinking that changing 12345 to "12345" was an edit. It isn't.

Test Plan

Created/edited events, no more extra "changed start time from X to the same X" transaction clutter.

Diff Detail

Repository

rP Phabricator

Branch

cimport4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14285
Build 18585: Run Core Tests
Build 18584: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40395.Oct 30 2016, 4:17 PM

epriestley retitled this revision from to Fix some extra "changed the start time of this event" transactions.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11326: Improve Calendar v1 Design/UI/UX.

chad accepted this revision.Oct 30 2016, 4:47 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 30 2016, 4:47 PM

Closed by commit rP5e784c998bae: Fix some extra "changed the start time of this event" transactions (authored by epriestley, committed by epriestley). · Explain WhyOct 30 2016, 5:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

form/

control/

AphrontFormDateControlValue.php

2 lines

Diff 40395

View Options

src/view/form/control/AphrontFormDateControlValue.php

Fix some extra "changed the start time of this event" transactionsClosedPublicActions