Paths

Table of Contentst

Differential D16772

Give organizers in ICS exports a dummy email address to placate Gmail
ClosedPublic
Actions

Authored by epriestley on Oct 30 2016, 4:13 PM.

Tags

None

Referenced Files

	F15337867: D16772.diff
	Sun, Mar 9, 8:04 AM

	F15332556: D16772.diff
	Fri, Mar 7, 5:56 PM

	F15306481: D16772.id.diff
	Thu, Mar 6, 4:06 AM

	F15306480: D16772.id40398.diff
	Thu, Mar 6, 4:06 AM

	F15306470: D16772.id40394.diff
	Thu, Mar 6, 4:05 AM

	F15306258: D16772.diff
	Thu, Mar 6, 3:50 AM

	F15304598: D16772.id40394.diff
	Thu, Mar 6, 1:55 AM

	Unknown Object (File)
	Tue, Feb 18, 11:57 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPe1a9b7694517: Give organizers in ICS exports a dummy email address to placate Gmail

Summary

Ref T10747. In the in-email ICS event card that Gmail shows, it has a "Who" field which reads "Unknown Organizer*" if the URI for the organizer isn't email-address-like.

Previously, we used a URI like https://phabricator.install.com/p/username, which I think is OK as far as RFC 5545 is concerned, but Gmail doesn't like it.

Instead, use PHID-USER-asdfa@phabricator.install.com, which doesn't go anywhere, but makes Gmail happy. Users don't normally see this URI anyway.

Test Plan

Got a readable "Who" in Gmail when importing an event exported from Calendar:

Screen Shot 2016-10-30 at 9.12.16 AM.png (272×525 px, 25 KB)

Diff Detail

Repository

Branch

cimport3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14284
Build 18583: Run Core Tests
Build 18582: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40394.Oct 30 2016, 4:13 PM

epriestley retitled this revision from to Give organizers in ICS exports a dummy email address to placate Gmail.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Oct 30 2016, 4:18 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 30 2016, 4:18 PM

Closed by commit rPe1a9b7694517: Give organizers in ICS exports a dummy email address to placate Gmail (authored by epriestley, committed by epriestley). · Explain WhyOct 30 2016, 4:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

storage/

PhabricatorCalendarEvent.php

14 lines

Diff 40394

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...