Differential D16771

Apply a TYPE_CREATE transaction when importing events to improve strings in timeline
ClosedPublic
Actions

Authored by epriestley on Oct 30 2016, 3:22 PM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPd9c91f857cef: Apply a TYPE_CREATE transaction when importing events to improve strings in…

Summary

Ref T10747. This turns on the newer EditEngine behavior so we get a nice "X created this event." transaction, instead of an "X renamed this from <nothing> to Event Name."

Test Plan

Imported an event, saw a nice timeline.

Diff Detail

Repository

rP Phabricator

Branch

cimport2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14283
Build 18581: Run Core Tests
Build 18580: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40393.Oct 30 2016, 3:22 PM

epriestley retitled this revision from to Apply a TYPE_CREATE transaction when importing events to improve strings in timeline.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Oct 30 2016, 3:54 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 30 2016, 3:54 PM

Closed by commit rPd9c91f857cef: Apply a TYPE_CREATE transaction when importing events to improve strings in… (authored by epriestley, committed by epriestley). · Explain WhyOct 30 2016, 4:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

editor/

PhabricatorCalendarEventEditor.php

9 lines

import/

PhabricatorCalendarImportEngine.php

6 lines

Diff 40393

View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php