Paths

Table of Contentst

Differential D16769

Fix a variant translation issue
ClosedPublic
Actions

Authored by epriestley on Oct 30 2016, 12:01 AM.

Details

Reviewers

chad

Maniphest Tasks

T11799: Garbage tool complains about invalid translation on 'set-policy' command

Commits

rP199300565142: Fix a variant translation issue

Summary

Fixes T11799. This string is varying on the first parameter, but should vary on the second parameter.

Test Plan

Ran bin/garbage set-policy ..., saw proper translation.

Diff Detail

Repository

rP Phabricator

Branch

policy1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14277
Build 18572: Run Core Tests
Build 18571: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40387.Oct 30 2016, 12:01 AM

epriestley retitled this revision from to Fix a variant translation issue.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley updated this object.Oct 30 2016, 12:01 AM

epriestley added a task: T11799: Garbage tool complains about invalid translation on 'set-policy' command.

chad accepted this revision.Oct 30 2016, 12:12 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 30 2016, 12:12 AM

Closed by commit rP199300565142: Fix a variant translation issue (authored by epriestley, committed by epriestley). · Explain WhyOct 30 2016, 12:12 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

internationalization/

translation/

PhabricatorUSEnglishTranslation.php

6 lines

Diff 40387

View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Fix a variant translation issueClosedPublicActions