Differential D16767

Fix an issue importing instantaneous events
ClosedPublic
Actions

Authored by epriestley on Oct 28 2016, 10:44 PM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPHUf62a265bad60: Fix an issue importing instantaneous events

Summary

Ref T10747. It's possible to define instantaneous events (no end date or duration) but we currently fail when trying to import them.

Test Plan

Imported an instantaneous event.

Diff Detail

Repository

rPHU libphutil

Branch

instantevent

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14270
Build 18561: Run Core Tests
Build 18560: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40380.Oct 28 2016, 10:44 PM

epriestley retitled this revision from to Fix an issue importing instantaneous events.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Oct 28 2016, 10:45 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 28 2016, 10:45 PM

Closed by commit rPHUf62a265bad60: Fix an issue importing instantaneous events (authored by epriestley, committed by epriestley). · Explain WhyOct 28 2016, 10:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

data/

PhutilCalendarEventNode.php

3 lines

Diff 40380

View Options

src/parser/calendar/data/PhutilCalendarEventNode.php

Fix an issue importing instantaneous eventsClosedPublicActions